At Aberdeen he made 386 appearances (53 as substitute) and scored 131 goals as well winning the Scottish League Cup and Scottish League with 'the Dons'. Before Aberdeen he played for Airdrieonians and after he played for Airdrie again and then St. Mirren. He was capped three times by the Scottish national side while with Airdrie in 1971.
Since retirement, he has and continues to be involved in various coaching capacities. This included serving as Ian Porterfield's assistant at South Korean club Busan I'cons during the 2003 K-League season.